This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
Set envoy log level as error to default in OSM #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduser25
reviewed
Sep 10, 2020
| @@ -30,6 +30,7 @@ IMAGE_PULL_POLICY="${IMAGE_PULL_POLICY:-Always}" | |||
| ENABLE_EGRESS="${ENABLE_EGRESS:-false}" | |||
| MESH_CIDR=$(./scripts/get_mesh_cidr.sh) | |||
| DEPLOY_WITH_SAME_SA="${DEPLOY_WITH_SAME_SA:-false}" | |||
| ENVOY_LOG_LEVEL="${ENVOY_LOG_LEVEL:-debug}" | |||
There was a problem hiding this comment.
Should the default be error?
There was a problem hiding this comment.
For the local development runs and the CI no, so that we can override the defaults in the install cli. Otherwise it would make it hard to debug CI failures.
We could set it to error here and override using env variables, but most use cases of the automated demo script are from CI and local development runs.
eduser25
previously approved these changes
Sep 10, 2020
shashankram
reviewed
Sep 10, 2020
snehachhabria
force-pushed
the
updatingEnvoylogLevel
branch
from
2fc73be to
31dfa01
Compare
shashankram
reviewed
Sep 10, 2020
shashankram
previously approved these changes
Sep 10, 2020
ksubrmnn
previously approved these changes
Sep 10, 2020
draychev
reviewed
Sep 10, 2020
| @@ -104,6 +104,10 @@ export BOOKWAREHOUSE_NAMESPACE=bookwarehouse | |||
| # optional: Whether to deploy traffic split policy or not | |||
| # Default: true | |||
| # export DEPLOY_TRAFFIC_SPLIT=true | |||
|
|
|||
| # optional: specify the log level for the enovy's | |||
| # Default: debug | |||
There was a problem hiding this comment.
Suggested change
| # Default: debug | |
| # Default: error |
There was a problem hiding this comment.
This is reflecting the default value for the demo script which is debug.
draychev
reviewed
Sep 10, 2020
snehachhabria
dismissed stale reviews from draychev, ksubrmnn, and shashankram
via
159692b
shashankram
approved these changes
Sep 10, 2020
draychev
approved these changes
Sep 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR :
errorwhen OSM is installedenvoy-log-levelas an install feature flag so that the demo and cli can run in the debug mode for envoyPlease mark with X for applicable areas.
Please answer the following questions with yes/no.
no