This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
ci: go mod tidy #1771
Merged
ci: go mod tidy #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksubrmnn
force-pushed
the
tidy_action
branch
from
24422c7 to
8cde8f0
Compare
ksubrmnn
force-pushed
the
tidy_action
branch
from
8cde8f0 to
b72934e
Compare
|
At the expense of yet another bash script, it would be great to invoke a check like this on the pre-push hook as well. |
draychev
previously approved these changes
Sep 29, 2020
shashankram
reviewed
Sep 30, 2020
shashankram
reviewed
Sep 30, 2020
scripts/go-mod-tidy.sh
Outdated
Comment on lines
3
to
5
| go mod tidy | ||
| if ! git diff --exit-code go.mod go.sum ; then | ||
| echo -e "\nPlease run 'go mod tidy' to clean up dependencies" |
There was a problem hiding this comment.
This script is already running go mod tidy, so is there a reason why it should be run again as echoed in L5?
There was a problem hiding this comment.
This script is also used by the CI so this is the message to let users know how to pass this check.
shashankram
previously approved these changes
Sep 30, 2020
shashankram
approved these changes
Sep 30, 2020
nojnhuh
approved these changes
Sep 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a Github Action for go mod tidy to keep dependencies cleaned up
Dependent on #1768
Please mark with X for applicable areas.
Please answer the following questions with yes/no.
No