Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

tests/catalog: remove assumption regarding ordering in list #1792

Merged
merged 1 commit into from
Oct 5, 2020

Conversation

shashankram
Copy link
Member

Description:
The order of traffic policy objects cannot be assumed, compare
presence of element in list instead along with checking the
length of the list.

Resolves #1791

Affected area:

  • New Functionality [ ]
  • Documentation [ ]
  • Install [ ]
  • Control Plane [ ]
  • CLI Tool [ ]
  • Certificate Management [ ]
  • Networking [ ]
  • Metrics [ ]
  • SMI Policy [ ]
  • Security [ ]
  • Tests [X]
  • CI System [ ]
  • Performance [ ]
  • Other [ ]

Please answer the following questions with yes/no.

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
    No

The order of traffic policy objects cannot be assumed, compare
presence of element in list instead along with checking the
length of the list.

Resolves openservicemesh#1791
@shashankram shashankram marked this pull request as ready for review October 5, 2020 22:07
@shashankram shashankram requested a review from a team as a code owner October 5, 2020 22:07
@shashankram shashankram merged commit c7e300b into openservicemesh:main Oct 5, 2020
@shashankram shashankram deleted the fix-test branch October 5, 2020 22:37
eduser25 pushed a commit to eduser25/osm that referenced this pull request Oct 14, 2020
…icemesh#1792)

The order of traffic policy objects cannot be assumed, compare
presence of element in list instead along with checking the
length of the list.

Resolves openservicemesh#1791
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit tests failure due to races
3 participants