Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

tests(catalog): fix flake in TestListTrafficPolicies #1808

Merged
merged 1 commit into from
Oct 9, 2020
Merged

tests(catalog): fix flake in TestListTrafficPolicies #1808

merged 1 commit into from
Oct 9, 2020

Conversation

nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Oct 9, 2020

Description: Change TestListTrafficPolicies to not test order of returned elements.

Affected area:

  • New Functionality [ ]
  • Documentation [ ]
  • Install [ ]
  • Control Plane [ ]
  • CLI Tool [ ]
  • Certificate Management [ ]
  • Networking [ ]
  • Metrics [ ]
  • SMI Policy [ ]
  • Security [ ]
  • Tests [X]
  • CI System [ ]
  • Performance [ ]
  • Other [ ]

Please answer the following questions with yes/no.

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
    No

@nojnhuh nojnhuh requested a review from a team as a code owner October 9, 2020 18:55
@codecov-io
Copy link

Codecov Report

Merging #1808 into main will increase coverage by 11.13%.
The diff coverage is 52.50%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1808       +/-   ##
===========================================
+ Coverage   44.39%   55.52%   +11.13%     
===========================================
  Files         111      125       +14     
  Lines        4690     5163      +473     
===========================================
+ Hits         2082     2867      +785     
+ Misses       2608     2294      -314     
- Partials        0        2        +2     
Impacted Files Coverage Δ
ci/cmd/maestro.go 8.04% <0.00%> (-2.67%) ⬇️
cmd/cli/dashboard.go 0.00% <ø> (ø)
cmd/cli/env.go 0.00% <0.00%> (ø)
cmd/cli/mesh.go 0.00% <0.00%> (ø)
cmd/cli/namespace.go 0.00% <0.00%> (ø)
cmd/cli/namespace_list.go 35.55% <0.00%> (-1.95%) ⬇️
cmd/cli/osm.go 0.00% <0.00%> (ø)
cmd/cli/version.go 0.00% <0.00%> (ø)
pkg/catalog/mock_catalog.go 0.00% <0.00%> (ø)
pkg/certificate/types.go 0.00% <ø> (ø)
... and 191 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48e1f23...55943d3. Read the comment docs.

@nojnhuh nojnhuh merged commit 5975f2a into openservicemesh:main Oct 9, 2020
@nojnhuh nojnhuh deleted the flaky-test branch October 9, 2020 19:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants