This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
tests(e2e): add vault test #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shashankram
reviewed
Oct 13, 2020
tests/e2e/e2e_hashivault_test.go
Outdated
| } | ||
| td.T.Logf("> REST req succeeded: %d", result.StatusCode) | ||
| return true | ||
| }, 5, 60*time.Second) |
There was a problem hiding this comment.
please wrap these values in constants/variables/inline comments to make the test more readable.
shashankram
approved these changes
Oct 13, 2020
eduser25
approved these changes
Oct 13, 2020
eduser25
pushed a commit
to eduser25/osm
that referenced
this pull request
Oct 14, 2020
* tests(e2e): add vault test * add comments for values
draychev
pushed a commit
to draychev/osm
that referenced
this pull request
Oct 28, 2020
* tests(e2e): add vault test * add comments for values
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR adds a new e2e test that uses HashiCorp Vault to issue certificates. It otherwise runs the same test as the original simple client/server test.
Affected area:
Please answer the following questions with yes/no.
No