tests(e2e): add egress test #1832
Conversation
| "edition.cnn.com", | ||
| "github.com", |
There was a problem hiding this comment.
We should be testing both HTTP and HTTPS traffic with egress.
Could you document what is being tested in the Describe or Context container.
There was a problem hiding this comment.
@shashankram Can you clarify what you mean by "what is being tested?"
There was a problem hiding this comment.
With egress there are different things that can be tested - HTTP egress, HTTPS egress etc.
It would be nice to document what is being tested as a part of the Describe and Context container messages.
There was a problem hiding this comment.
Ginkgo's way would be to have the test separated by It()s, so that each seaction represents a part of the test. We are not yet there in current impl, but we should file an issue to rework the tests into sections.
There was a problem hiding this comment.
You don't need an It() for every test, depends on what is being tested. Just a Describe and Context are more than enough for many tests.
# Conflicts: # tests/e2e/common_traffic.go
Codecov Report
@@ Coverage Diff @@
## main #1832 +/- ##
==========================================
- Coverage 59.09% 59.07% -0.02%
==========================================
Files 125 125
Lines 5171 5171
==========================================
- Hits 3056 3055 -1
- Misses 2112 2113 +1
Partials 3 3
Continue to review full report at Codecov.
|
tests/e2e/e2e_egress_test.go
Outdated
| "http://", | ||
| "https://", | ||
| } | ||
| egressTests := []string{ |
There was a problem hiding this comment.
| egressTests := []string{ | |
| egressURLs := []string{ |
* tests(e2e): add egress test * check http and https * log urls for requests after disabling egress * address comments
Description: This test will issue requests against edition.cnn.com and github.com both with egress enabled, ensure the requests are successful, disable egress, issue the same requests, and ensure those requests fail.
Affected area:
Please answer the following questions with yes/no.
No