This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
tests/e2e: Generalize GetEnv #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1844 +/- ##
==========================================
- Coverage 59.21% 59.19% -0.02%
==========================================
Files 125 125
Lines 5171 5171
==========================================
- Hits 3062 3061 -1
- Misses 2106 2107 +1
Partials 3 3
Continue to review full report at Codecov.
|
shashankram
reviewed
Oct 14, 2020
tests/e2e/common.go
Outdated
Comment on lines
76
to
83
| func GetEnv(envVar string, defaultValue string) string { | ||
| val := os.Getenv(envVar) | ||
| if val == "" { | ||
| return defaultValue | ||
| } | ||
| return val | ||
| } | ||
|
|
There was a problem hiding this comment.
This is implemented in at lease one other file:
Line 97 in c98e255
Might as well move this under pkg/utils and use that.
There was a problem hiding this comment.
let me try. I hope not to run into cyclic imports.
shashankram
approved these changes
Oct 16, 2020
nojnhuh
approved these changes
Oct 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing comment from previous PR #1828 (comment)
Affected area:
Tests [X]
CI System [X]
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
No