This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
tests/e2e: force always pull in non kind-based deployment #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1849 +/- ##
==========================================
- Coverage 59.21% 59.07% -0.14%
==========================================
Files 125 125
Lines 5171 5171
==========================================
- Hits 3062 3055 -7
- Misses 2106 2113 +7
Partials 3 3
Continue to review full report at Codecov.
|
OSM install sets `ImagePullPolicy` to `IfNotPresent` by default, making quick test-update-test iterations not pull new tags if the tag is already present in nodes (but not latest SHA).
nojnhuh
approved these changes
Oct 15, 2020
shashankram
approved these changes
Oct 15, 2020
snehachhabria
approved these changes
Oct 15, 2020
draychev
pushed a commit
to draychev/osm
that referenced
this pull request
Oct 28, 2020
…emesh#1849) OSM install sets `ImagePullPolicy` to `IfNotPresent` by default, making quick test-update-test iterations not pull new tags if the tag is already present in nodes (but not latest SHA).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seen a condition where OSM is not necessarily always pulled if present in
container cache in nodes (even with
latesttag) and registry is enabled.Verified this was the case comparing SHAs.
Not sure the reason though.Reason is install cli sets
imagePullPolicytoIfNotPresentby default (and never omitted)https://kubernetes.io/docs/concepts/containers/images/#updating-images
Affected area:
Tests [X]
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
No