This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
cli: Add enforce single mesh functionality to osm install #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1854 +/- ##
==========================================
+ Coverage 59.09% 59.15% +0.05%
==========================================
Files 125 125
Lines 5171 5183 +12
==========================================
+ Hits 3056 3066 +10
- Misses 2112 2114 +2
Partials 3 3
Continue to review full report at Codecov.
|
shashankram
reviewed
Oct 16, 2020
cmd/cli/install.go
Outdated
Comment on lines
308
to
310
| singleMeshEnforced := mesh.ObjectMeta.Labels["enforceSingleMesh"] == "true" | ||
| name := mesh.ObjectMeta.Labels["meshName"] | ||
| if singleMeshEnforced { |
There was a problem hiding this comment.
Since the single mesh feature is a cluster wide configuration, should we introduce semantics for cluster wide configurations, such as a configMap in the default namespace, as opposed to labels on deployments?
There was a problem hiding this comment.
Per offline discussions with the team, we will push this out until later when more cluster wide configurations arise.
shashankram
previously approved these changes
Oct 19, 2020
shashankram
approved these changes
Oct 19, 2020
snehachhabria
approved these changes
Oct 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
--enable-single-mesh enforces that only one mesh is installed in the cluster
Fixes #1754
Affected area:
Please answer the following questions with yes/no.
No