This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
ref(make): add variables for e2e test flags #1857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds two new variables to the Makefile to handle e2e test flags: `E2E_FLAGS` and `E2E_FLAGS_DEFAULT`. These flags can optionally be defined on the command line while invoking `make test-e2e` so flags can be modified while also automatically building the required images. Two separate flags were created so a sensible set of defaults can be kept in `E2E_FLAGS_DEFAULT` and flags more likely to be changed like cleanup or focus can be overridden without redefining all the default flags. The default flags include verbose output and image parameters, so the `test-e2e` target will always test with locally built images from the current source. To use pre-built images, `go test` should be invoked directly. The default behavior for `make test-e2e` is unchanged.
eduser25
approved these changes
Oct 16, 2020
shashankram
approved these changes
Oct 16, 2020
draychev
pushed a commit
to draychev/osm
that referenced
this pull request
Oct 28, 2020
This change adds two new variables to the Makefile to handle e2e test flags: `E2E_FLAGS` and `E2E_FLAGS_DEFAULT`. These flags can optionally be defined on the command line while invoking `make test-e2e` so flags can be modified while also automatically building the required images. Two separate flags were created so a sensible set of defaults can be kept in `E2E_FLAGS_DEFAULT` and flags more likely to be changed like cleanup or focus can be overridden without redefining all the default flags. The default flags include verbose output and image parameters, so the `test-e2e` target will always test with locally built images from the current source. To use pre-built images, `go test` should be invoked directly. The default behavior for `make test-e2e` is unchanged.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change adds two new variables to the Makefile to handle e2e test
flags:
E2E_FLAGSandE2E_FLAGS_DEFAULT. These flags can optionallybe defined on the command line while invoking
make test-e2eso flagscan be modified while also automatically building the required images.
Two separate flags were created so a sensible set of
defaults can be kept in
E2E_FLAGS_DEFAULTand flags more likely to bechanged like cleanup or focus can be overridden without redefining all
the default flags. The default flags include verbose output and image
parameters, so the
test-e2etarget will always test with locally builtimages from the current source. To use pre-built images,
go testshould be invoked directly.
The default behavior for
make test-e2eis unchanged.Affected area:
Please answer the following questions with yes/no.
No