This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
ref(test): Use distinct weights for weighted clusters #1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snehachhabria
previously approved these changes
Oct 16, 2020
shashankram
previously approved these changes
Oct 16, 2020
ksubrmnn
dismissed stale reviews from shashankram and snehachhabria
via
96a224f
snehachhabria
approved these changes
Oct 17, 2020
nojnhuh
approved these changes
Oct 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR refactors tests to use distinct weights for the test weighted clusters. Previously, having the default weight and the traffic split backend weight both equal to 100 led to using the wrong weight in rds/response_test.go but the test still passed as they were equal.
Affected area:
Please answer the following questions with yes/no.
No