This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
CI cleanup timeout increase #1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With enough test applications/namespaces in combination with a slow instance of gh actions, we've seen some delays to clean up all test namespaces and test failures. Relaxing further the wait-for-namespaces cleanup time, as re-running the test suite for a non-osm-related issue is a lot more expensive compared to grating additional infra cleanup time.
eduser25
force-pushed
the
CI-cleanup-increase
branch
from
ff7795d to
79abda2
Compare
Codecov Report
@@ Coverage Diff @@
## main #1864 +/- ##
==========================================
+ Coverage 59.22% 59.28% +0.05%
==========================================
Files 126 126
Lines 5175 5177 +2
==========================================
+ Hits 3065 3069 +4
+ Misses 2107 2105 -2
Partials 3 3
Continue to review full report at Codecov.
|
snehachhabria
approved these changes
Oct 16, 2020
nojnhuh
approved these changes
Oct 19, 2020
draychev
pushed a commit
to draychev/osm
that referenced
this pull request
Oct 28, 2020
With enough test applications/namespaces in combination with a slow instance of gh actions, we've seen some delays to clean up all test namespaces and test failures. Relaxing further the wait-for-namespaces cleanup time, as re-running the test suite for a non-osm-related issue is a lot more expensive compared to grating additional infra cleanup time.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With enough test applications/namespaces in combination with a slow
instance of gh actions, we've seen some delays to clean up all test
namespaces, and consequently test failures.
Relaxing further the wait-for-namespaces cleanup time, as re-running
the test suite for a non-osm-related/infra timeout can be a lot more expensive
than grating additional infra cleanup time.
Affected area:
Tests [X]
CI System [X]
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
No