This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 277
doc(doc/config.md) : Documentation for OSM ConfigMap #1870
Merged
snehachhabria
merged 4 commits into
openservicemesh:main
from
snehachhabria:snehachhabria-configMap-doc
Oct 20, 2020
Merged
doc(doc/config.md) : Documentation for OSM ConfigMap #1870
snehachhabria
merged 4 commits into
openservicemesh:main
from
snehachhabria:snehachhabria-configMap-doc
Oct 20, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snehachhabria
changed the title
<doc> : Documentation for OSM ConfigMap
doc(/doc/config.md) : Documentation for OSM ConfigMap
Oct 19, 2020
snehachhabria
changed the title
doc(/doc/config.md) : Documentation for OSM ConfigMap
doc(doc/config.md) : Documentation for OSM ConfigMap
Oct 19, 2020
shashankram
suggested changes
Oct 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very useful change, left some comments regarding wording.
shashankram
reviewed
Oct 19, 2020
shashankram
previously approved these changes
Oct 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@snehachhabria should we rename the doc to |
we could, would that be better ? |
eduser25
previously approved these changes
Oct 20, 2020
snehachhabria
dismissed stale reviews from eduser25 and shashankram
via
October 20, 2020 17:32
0f352f7
snehachhabria
force-pushed
the
snehachhabria-configMap-doc
branch
from
October 20, 2020 17:32
b852b48
to
0f352f7
Compare
shashankram
approved these changes
Oct 20, 2020
eduser25
approved these changes
Oct 20, 2020
draychev
pushed a commit
to draychev/osm
that referenced
this pull request
Oct 28, 2020
…#1870) Documentation for OSM ConfigMap
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds documentation for OSM ConfigMap
Fixes : #1842
Affected area:
Please answer the following questions with yes/no.
no