Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

doc(doc/config.md) : Documentation for OSM ConfigMap #1870

Merged

Conversation

snehachhabria
Copy link
Contributor

Description:
This PR adds documentation for OSM ConfigMap

Fixes : #1842

Affected area:

  • New Functionality [ ]
  • Documentation [X]
  • Install [ ]
  • Control Plane [ ]
  • CLI Tool [ ]
  • Certificate Management [ ]
  • Networking [ ]
  • Metrics [ ]
  • SMI Policy [ ]
  • Security [ ]
  • Tests [ ]
  • CI System [ ]
  • Performance [ ]
  • Other [ ]

Please answer the following questions with yes/no.

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution? no

@snehachhabria snehachhabria requested a review from a team as a code owner October 19, 2020 23:04
@snehachhabria snehachhabria changed the title <doc> : Documentation for OSM ConfigMap doc(/doc/config.md) : Documentation for OSM ConfigMap Oct 19, 2020
@snehachhabria snehachhabria changed the title doc(/doc/config.md) : Documentation for OSM ConfigMap doc(doc/config.md) : Documentation for OSM ConfigMap Oct 19, 2020
Copy link
Member

@shashankram shashankram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very useful change, left some comments regarding wording.

docs/config.md Outdated Show resolved Hide resolved
docs/config.md Outdated Show resolved Hide resolved
docs/config.md Outdated Show resolved Hide resolved
docs/config.md Outdated Show resolved Hide resolved
docs/config.md Outdated Show resolved Hide resolved
docs/config.md Outdated Show resolved Hide resolved
docs/config.md Outdated Show resolved Hide resolved
docs/config.md Outdated Show resolved Hide resolved
docs/config.md Outdated Show resolved Hide resolved
shashankram
shashankram previously approved these changes Oct 19, 2020
Copy link
Member

@shashankram shashankram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@shashankram
Copy link
Member

@snehachhabria should we rename the doc to docs/osm_config_map.md?

@snehachhabria
Copy link
Contributor Author

@snehachhabria should we rename the doc to docs/osm_config_map.md?

we could, would that be better ?

eduser25
eduser25 previously approved these changes Oct 20, 2020
@snehachhabria snehachhabria dismissed stale reviews from eduser25 and shashankram via 0f352f7 October 20, 2020 17:32
@snehachhabria snehachhabria force-pushed the snehachhabria-configMap-doc branch from b852b48 to 0f352f7 Compare October 20, 2020 17:32
@snehachhabria snehachhabria merged commit 59876f8 into openservicemesh:main Oct 20, 2020
@snehachhabria snehachhabria deleted the snehachhabria-configMap-doc branch October 20, 2020 21:13
draychev pushed a commit to draychev/osm that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document OSM ConfigMap - possible keys, values, and the effects these have
3 participants