This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
fix(e2e): cleanup helm releases in e2e #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will uninstall all Helm releases in the namespaces being cleaned up before deleting the namespaces to avoid the namespaces getting stuck in a Terminating state. Fixes #1880
eduser25
reviewed
Oct 22, 2020
tests/e2e/common.go
Outdated
| @@ -820,7 +820,26 @@ func (td *OsmTestData) Cleanup(ct CleanupType) { | |||
| } | |||
|
|
|||
| for _, ns := range testNs.Items { | |||
| err := td.DeleteNs(ns.Name) | |||
| // Delete Helm releases created in the namespace | |||
There was a problem hiding this comment.
Question. Would it be help if this was run defacto on DeleteNs code? Just in case someone decided to manually run a DeleteNs individually (as part of the test) on an NS that had helm resources.
I'm ok eitherway though
There was a problem hiding this comment.
Good call. I'll make that change.
eduser25
previously approved these changes
Oct 22, 2020
Codecov Report
@@ Coverage Diff @@
## main #1886 +/- ##
=======================================
Coverage ? 58.34%
=======================================
Files ? 129
Lines ? 5267
Branches ? 0
=======================================
Hits ? 3073
Misses ? 2191
Partials ? 3 Continue to review full report at Codecov.
|
michelleN
approved these changes
Oct 23, 2020
draychev
pushed a commit
to draychev/osm
that referenced
this pull request
Oct 28, 2020
This change will uninstall all Helm releases in the namespaces being cleaned up before deleting the namespaces to avoid the namespaces getting stuck in a Terminating state. Fixes openservicemesh#1880
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change will uninstall all Helm releases in the namespaces being
cleaned up before deleting the namespaces to avoid the namespaces
getting stuck in a Terminating state.
Fixes #1880
Affected area:
Please answer the following questions with yes/no.
No