This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
tests/e2e: add NoInstall option #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1894 +/- ##
==========================================
+ Coverage 58.42% 58.55% +0.13%
==========================================
Files 129 129
Lines 5267 5267
==========================================
+ Hits 3077 3084 +7
+ Misses 2187 2180 -7
Partials 3 3
Continue to review full report at Codecov.
|
eduser25
force-pushed
the
noinstall-e2e
branch
from
252292d to
6cf705c
Compare
eduser25
commented
Oct 22, 2020
nojnhuh
suggested changes
Oct 22, 2020
| case SelfInstall: | ||
| fallthrough | ||
| case KindCluster: | ||
| fallthrough |
There was a problem hiding this comment.
Not sure I've ever actually seen fallthrough used before in the wild. 😄
nojnhuh
previously approved these changes
Oct 22, 2020
Adds new install option `NoInstall`. NoInstall means to run the tests assuming there is already a running instance of OSM in namespace `osmNamespace`, part of the test suite flags. OSM will therefore not be installed/cleaned up between tests, all other resources used by the tests (clients, other namespaces, etc) will get cleaned though. Since a single install is assumed, it assumes inmutability of the install, so tests that _require_ or test specific parts of the installation will be skipped. Dynamic configuration (configmap) is however supported, and tests that would usually call Install will instead set/reset the dynamic config map values that the install command would originally set. [] rebase
eduser25
force-pushed
the
noinstall-e2e
branch
from
5f39e66 to
d04b425
Compare
shashankram
approved these changes
Oct 23, 2020
nojnhuh
approved these changes
Oct 23, 2020
draychev
pushed a commit
to draychev/osm
that referenced
this pull request
Oct 28, 2020
* tests/e2e: add NoInstall option Adds new install option `NoInstall`. NoInstall means to run the tests assuming there is already a running instance of OSM in namespace `osmNamespace`, part of the test suite flags. OSM will therefore not be installed/cleaned up between tests, all other resources used by the tests (clients, other namespaces, etc) will get cleaned though. Since a single install is assumed, it assumes inmutability of the install, so tests that _require_ or test specific parts of the installation will be skipped. Dynamic configuration (configmap) is however supported, and tests that would usually call Install will instead set/reset the dynamic config map values that the install command would originally set. [] rebase
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new e2e install option
NoInstall.NoInstall means to run the tests assuming there is already
a running, permanent instance of OSM in namespace
osmNamespace, partof the test suite flags.
OSM will therefore not be installed/cleaned up between tests,
all other resources used by the tests (clients, other namespaces,
SMI defs, etc) will get cleaned though.
Since a single install is assumed, it assumes inmutability of the
install, so tests that require or test specific parts of the
installation will be skipped.
Dynamic configuration (configmap) is however supported, and tests
that would usually call Install will instead set/reset the dynamic
config map values that the install command would originally set.
Affected area:
New Functionality [X]
Tests [X]
CI System [X]
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
No