Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

catalog/routes: Change log level for ListTrafficPolicies from Info to Trace #1923

Merged
merged 1 commit into from
Oct 27, 2020
Merged

catalog/routes: Change log level for ListTrafficPolicies from Info to Trace #1923

merged 1 commit into from
Oct 27, 2020

Conversation

draychev
Copy link
Contributor

I noticed that ListTrafficPolicies was emiting a bit too many log lines. To lower the noise, I propose we emit Listing traffic policies for service... at Trace level.

This PR also adds more detail to the getHTTPPathsPerRoute() error message.

Please answer the following questions with yes/no.

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
    no

@draychev draychev requested a review from a team as a code owner October 27, 2020 00:37
snehachhabria
snehachhabria approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@snehachhabria snehachhabria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this :)

@draychev draychev merged commit 92b5699 into openservicemesh:main Oct 27, 2020
@draychev draychev deleted the routes-lower-logs branch October 27, 2020 16:14
draychev added a commit to draychev/osm that referenced this pull request Oct 28, 2020
@draychev
catalog/routes: Change log level for ListTrafficPolicies from Info to…
cfbac8f 
… Trace (openservicemesh#1923)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@snehachhabria snehachhabria snehachhabria approved these changes

@nojnhuh nojnhuh nojnhuh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@draychev @nojnhuh @snehachhabria