Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

ref(build): consolidate version Makefile variables #1936

Merged
merged 1 commit into from
Oct 28, 2020
Merged

ref(build): consolidate version Makefile variables #1936

merged 1 commit into from
Oct 28, 2020

Conversation

nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Oct 27, 2020

Description:
This change combines the CLI_VERSION and CONTROLLER_VERSION Makefile variables into a single VERSION variable since they were being used for the same purpose.

Affected area:

  • New Functionality [ ]
  • Documentation [ ]
  • Install [ ]
  • Control Plane [ ]
  • CLI Tool [ ]
  • Certificate Management [ ]
  • Networking [ ]
  • Metrics [ ]
  • SMI Policy [ ]
  • Security [ ]
  • Tests [ ]
  • CI System [X]
  • Performance [ ]
  • Other [ ]

Please answer the following questions with yes/no.

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
    No

@nojnhuh nojnhuh requested a review from a team as a code owner October 27, 2020 21:35
@codecov-io
Copy link

Codecov Report

Merging #1936 into main will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1936      +/-   ##
==========================================
+ Coverage   58.43%   58.50%   +0.06%     
==========================================
  Files         131      131              
  Lines        5266     5270       +4     
==========================================
+ Hits         3077     3083       +6     
+ Misses       2186     2184       -2     
  Partials        3        3              
Impacted Files Coverage Δ
pkg/envoy/route/config.go 95.83% <0.00%> (+0.83%) ⬆️
pkg/injector/webhook.go 72.28% <0.00%> (+1.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa0445c...526256d. Read the comment docs.

@nojnhuh nojnhuh merged commit b45ab46 into openservicemesh:main Oct 28, 2020
@nojnhuh nojnhuh deleted the make-version branch October 28, 2020 18:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants