Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Reduce default number of bits used per RSA certificate key to 2048 #1940

Merged
merged 2 commits into from
Oct 28, 2020

Conversation

eduser25
Copy link
Contributor

@eduser25 eduser25 commented Oct 27, 2020

Trading off bits on RSA key size for performance.

Shows a 12x to 15x less time spent generating certificates, which right
now is synchronous inside webhook handling.

see #1931 for additional context
fixes #1931

Affected area:

  • Control Plane [X]
  • Certificate Management [X]
  • Security [X]
  • Performance [X]

Please answer the following questions with yes/no.

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
    No

@eduser25 eduser25 requested a review from a team as a code owner October 27, 2020 22:54
Trading off bits on RSA key generation for performance.

Shows a 12x to 15x less time spent generating certificates, which right
now is synchronous with webhook.
@codecov-io
Copy link

Codecov Report

Merging #1940 into main will decrease coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1940      +/-   ##
==========================================
- Coverage   58.50%   58.30%   -0.20%     
==========================================
  Files         131      131              
  Lines        5270     5272       +2     
==========================================
- Hits         3083     3074       -9     
- Misses       2184     2195      +11     
  Partials        3        3              
Impacted Files Coverage Δ
...ertificate/providers/tresor/certificate_manager.go 64.04% <0.00%> (-12.36%) ⬇️
pkg/catalog/routes.go 77.77% <0.00%> (ø)
pkg/catalog/mock_catalog.go 0.00% <0.00%> (ø)
pkg/kubernetes/util.go 95.00% <0.00%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85a6597...abd4500. Read the comment docs.

@eduser25 eduser25 merged commit cc8d85c into openservicemesh:main Oct 28, 2020
@eduser25 eduser25 deleted the rsabits branch October 28, 2020 04:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce default 4096bit key size to 2048 for certs
4 participants