Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

endpoint: Rename variable to remove collision w/ imported package #1973

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

draychev
Copy link
Contributor

@draychev draychev commented Nov 3, 2020

This is a noop change, which renames a variable from service to kubeService to avoid collision w/ an imported package.

No functional code changes.

Affected area:

  • New Functionality [ ]
  • Documentation [ ]
  • Install [ ]
  • Control Plane [ ]
  • CLI Tool [ ]
  • Certificate Management [ ]
  • Networking [ ]
  • Metrics [ ]
  • SMI Policy [ ]
  • Security [ ]
  • Tests [ ]
  • CI System [ ]
  • Performance [ ]
  • Other [ ]

Please answer the following questions with yes/no.

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

@draychev draychev requested a review from a team as a code owner November 3, 2020 01:38
@codecov-io
Copy link

Codecov Report

Merging #1973 into main will increase coverage by 0.01%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1973      +/-   ##
==========================================
+ Coverage   57.50%   57.52%   +0.01%     
==========================================
  Files         136      136              
  Lines        5462     5462              
==========================================
+ Hits         3141     3142       +1     
+ Misses       2318     2317       -1     
  Partials        3        3              
Impacted Files Coverage Δ
pkg/endpoint/providers/kube/client.go 83.76% <80.00%> (ø)
pkg/envoy/route/config.go 96.03% <0.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cffdc91...de28567. Read the comment docs.

Copy link
Member

@shashankram shashankram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another common example of this problem is with using the variable name catalog that collides with the package name.

@draychev draychev merged commit dd937a3 into openservicemesh:main Nov 3, 2020
@draychev draychev deleted the rename-var branch November 3, 2020 16:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants