Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

test(cli/install): Refactor tests to use default install commands #1998

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

ksubrmnn
Copy link
Contributor

@ksubrmnn ksubrmnn commented Nov 6, 2020

Description:
This PR uses the default install command and the default values map for all tests. This cuts down on the number of lines of code considerably, making this file easier to read and edit.

Additionally, new tests were being added by copying old tests. This resulted in each test configuring certain settings in different ways across the tests even though no meaningful difference was made by these changed settings. For example, a test for checking the namespace could include settings that were used in a test for cert-manager.

This made the tests more difficult to interpret as it was not possible to tell exactly which fields were necessary for the testing scenario. However this new format makes it easy to see which settings differ from the default.

Affected area:

  • New Functionality [ ]
  • Documentation [ ]
  • Install [ ]
  • Control Plane [ ]
  • CLI Tool [ ]
  • Certificate Management [ ]
  • Networking [ ]
  • Metrics [ ]
  • SMI Policy [ ]
  • Security [ ]
  • Tests [X]
  • CI System [ ]
  • Performance [ ]
  • Other [ ]

Please answer the following questions with yes/no.

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
    No

@ksubrmnn ksubrmnn requested a review from a team as a code owner November 6, 2020 01:15
@ksubrmnn ksubrmnn changed the title test(cli/install): Refactor tests to use default install commands" test(cli/install): Refactor tests to use default install commands Nov 6, 2020
@ksubrmnn ksubrmnn merged commit 3456647 into openservicemesh:main Nov 9, 2020
@ksubrmnn ksubrmnn deleted the install_test branch November 9, 2020 21:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants