This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
test(cli/install): Refactor tests to use default install commands #1998
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR uses the default install command and the default values map for all tests. This cuts down on the number of lines of code considerably, making this file easier to read and edit.
Additionally, new tests were being added by copying old tests. This resulted in each test configuring certain settings in different ways across the tests even though no meaningful difference was made by these changed settings. For example, a test for checking the namespace could include settings that were used in a test for cert-manager.
This made the tests more difficult to interpret as it was not possible to tell exactly which fields were necessary for the testing scenario. However this new format makes it easy to see which settings differ from the default.
Affected area:
Please answer the following questions with yes/no.
No