Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

catalog: Refactor repeater() for clarity and to remove indentation level #2032

Merged
merged 1 commit into from
Nov 11, 2020
Merged

catalog: Refactor repeater() for clarity and to remove indentation level #2032

merged 1 commit into from
Nov 11, 2020

Conversation

draychev
Copy link
Contributor

This PR is an overall noop:

  • removes an indentation level by using continue
  • adds a log message for when (if ever) a message does not assert to Announcement
  • augments the log message, which reports the type of announcement and the system it came from

Affected area:

  • New Functionality [ ]
  • Documentation [ ]
  • Install [ ]
  • Control Plane [ ]
  • CLI Tool [ ]
  • Certificate Management [ ]
  • Networking [ ]
  • Metrics [ ]
  • SMI Policy [ ]
  • Security [ ]
  • Tests [ ]
  • CI System [ ]
  • Performance [ ]
  • Other [X]

Please answer the following questions with yes/no.

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution? no

@draychev draychev requested a review from a team as a code owner November 11, 2020 22:29
shashankram
shashankram approved these changes Nov 11, 2020
View reviewed changes
Copy link
Member

@shashankram shashankram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should start having _test.go files for unit testing new changes.

@draychev draychev merged commit e50d75b into openservicemesh:main Nov 11, 2020
@draychev draychev deleted the cleanup-repeater branch November 11, 2020 23:59
draychev added a commit to draychev/osm that referenced this pull request Nov 19, 2020
@draychev
catalog: Refactor repeater() for clarity (openservicemesh#2032)
47be253
draychev added a commit to draychev/osm that referenced this pull request Nov 19, 2020
@draychev
catalog: Refactor repeater() for clarity (openservicemesh#2032)
d28fc40
draychev added a commit to draychev/osm that referenced this pull request Dec 14, 2020
@draychev
catalog: Refactor repeater() for clarity (openservicemesh#2032)
c436fa0
@draychev draychev linked an issue Jan 28, 2021 that may be closed by this pull request
Optimize announcement channels and XDS config push in osm-controller #1913
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michelleN michelleN michelleN approved these changes

@eduser25 eduser25 eduser25 approved these changes

@shashankram shashankram shashankram approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize announcement channels and XDS config push in osm-controller
4 participants
@draychev @michelleN @eduser25 @shashankram