This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
osm-deployment: parametrize osm log level in values.yaml #2046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it's hardcoded in deployment. This gives at least some short term flexibility till we add configMap update, which has some ongoing discussion as how to tackle.
eduser25
changed the title
eduser25
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2046 +/- ##
==========================================
+ Coverage 57.30% 57.45% +0.14%
==========================================
Files 139 139
Lines 5692 5702 +10
==========================================
+ Hits 3262 3276 +14
+ Misses 2427 2424 -3
+ Partials 3 2 -1
Continue to review full report at Codecov.
|
shashankram
previously approved these changes
Nov 12, 2020
ksubrmnn
previously approved these changes
Nov 13, 2020
snehachhabria
approved these changes
Nov 13, 2020
shashankram
approved these changes
Nov 13, 2020
draychev
pushed a commit
to draychev/osm
that referenced
this pull request
Nov 19, 2020
…mesh#2046) * osm-deployment: parametrize log level. Currently it's hardcoded in deployment. This gives at least some short term flexibility till we add configMap update, which has some ongoing discussion as how to tackle. * address comments
draychev
pushed a commit
to draychev/osm
that referenced
this pull request
Nov 19, 2020
…mesh#2046) * osm-deployment: parametrize log level. Currently it's hardcoded in deployment. This gives at least some short term flexibility till we add configMap update, which has some ongoing discussion as how to tackle. * address comments
draychev
pushed a commit
to draychev/osm
that referenced
this pull request
Dec 14, 2020
…mesh#2046) * osm-deployment: parametrize log level. Currently it's hardcoded in deployment. This gives at least some short term flexibility till we add configMap update, which has some ongoing discussion as how to tackle. * address comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's hardcoded in deployment.
This gives at least some short term flexibility till we add
configMap update, which has some ongoing discussion as
how to tackle.
Install [X]
Control Plane [X]
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
No