This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
envoy/rbac: add support for server side RBAC fitler #2054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draychev
reviewed
Nov 13, 2020
| mockCatalog := catalog.NewMockMeshCataloger(mockCtrl) | ||
| proxySvcAccount := service.K8sServiceAccount{Name: "sa-1", Namespace: "ns-1"} | ||
|
|
||
| lb := &listenerBuilder{ |
There was a problem hiding this comment.
Why not use newListenerBuilder()?
There was a problem hiding this comment.
Because this allows to fill in minimal stuff into the object needed to build the filter. When a new field is added to the struct, if the test fails it helps find dependency issues faster.
eduser25
previously approved these changes
Nov 13, 2020
This change introduces an RBAC filter in the inbound mesh filter chain. Currently, the RBAC filter grants full access to client identities that are permitted by an SMI traffic target policy. HTTP filtering based on HTTP routes still happens within RDS. The RBAC filter is omitted in permissive mode. This change is a part of openservicemesh#1964 and is required by openservicemesh#1521.
draychev
approved these changes
Nov 13, 2020
eduser25
approved these changes
Nov 13, 2020
draychev
pushed a commit
to draychev/osm
that referenced
this pull request
Nov 19, 2020
…2054) This change introduces an RBAC filter in the inbound mesh filter chain. Currently, the RBAC filter grants full access to client identities that are permitted by an SMI traffic target policy. HTTP filtering based on HTTP routes still happens within RDS. The RBAC filter is omitted in permissive mode. This change is a part of openservicemesh#1964 and is required by openservicemesh#1521.
draychev
pushed a commit
to draychev/osm
that referenced
this pull request
Nov 19, 2020
…2054) This change introduces an RBAC filter in the inbound mesh filter chain. Currently, the RBAC filter grants full access to client identities that are permitted by an SMI traffic target policy. HTTP filtering based on HTTP routes still happens within RDS. The RBAC filter is omitted in permissive mode. This change is a part of openservicemesh#1964 and is required by openservicemesh#1521.
draychev
pushed a commit
to draychev/osm
that referenced
this pull request
Dec 14, 2020
…2054) This change introduces an RBAC filter in the inbound mesh filter chain. Currently, the RBAC filter grants full access to client identities that are permitted by an SMI traffic target policy. HTTP filtering based on HTTP routes still happens within RDS. The RBAC filter is omitted in permissive mode. This change is a part of openservicemesh#1964 and is required by openservicemesh#1521.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change introduces an RBAC filter in the inbound mesh filter
chain. Currently, the RBAC filter grants full access to client identities
(ServiceAccounts) that are permitted by an SMI traffic target policy.
HTTP filtering based on HTTP routes still happens within RDS.
The RBAC filter is omitted in permissive mode.
This change is a part of #1964 and is required by #1521.
Affected area:
Please answer the following questions with yes/no.
No