Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

certificate/vault: Change cache from a map to sync.Map #2074

Merged
merged 2 commits into from
Nov 18, 2020

Conversation

draychev
Copy link
Contributor

This PR removes the cacheLock mutex from Certificate{} and uses a sync.Map instead of *map[certificate.CommonName]certificate.Certificater

ref #507


Affected area:

  • New Functionality [ ]
  • Documentation [ ]
  • Install [ ]
  • Control Plane [ ]
  • CLI Tool [ ]
  • Certificate Management [ ]
  • Networking [ ]
  • Metrics [ ]
  • SMI Policy [ ]
  • Security [ ]
  • Tests [ ]
  • CI System [ ]
  • Performance [ ]
  • Other [ ]

Please answer the following questions with yes/no.

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

@draychev draychev requested a review from a team as a code owner November 17, 2020 01:44
@codecov-io
Copy link

codecov-io commented Nov 17, 2020

Codecov Report

Merging #2074 (b83626b) into main (aa9409e) will increase coverage by 0.05%.
The diff coverage is 45.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2074      +/-   ##
==========================================
+ Coverage   57.93%   57.99%   +0.05%     
==========================================
  Files         143      143              
  Lines        5851     5842       -9     
==========================================
- Hits         3390     3388       -2     
+ Misses       2458     2451       -7     
  Partials        3        3              
Impacted Files Coverage Δ
pkg/certificate/providers/vault/types.go 100.00% <ø> (ø)
...certificate/providers/vault/certificate_manager.go 50.00% <25.00%> (+1.80%) ⬆️
pkg/certificate/providers/vault/debugger.go 100.00% <100.00%> (ø)
pkg/envoy/route/config.go 96.03% <0.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa9409e...b83626b. Read the comment docs.

snehachhabria
snehachhabria previously approved these changes Nov 17, 2020
ksubrmnn
ksubrmnn previously approved these changes Nov 17, 2020
@draychev draychev merged commit 4907ddf into openservicemesh:main Nov 18, 2020
@draychev draychev deleted the use-sync-map branch November 18, 2020 17:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants