This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
ref(xds): use PodMetadata struct in place of individual fields #2079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change cleans up a couple of function signatures related to the pod metadata tied to each Envoy proxy by returning the entire struct vs. each field individually to make it more ergonomic.
ksubrmnn
approved these changes
Nov 17, 2020
snehachhabria
approved these changes
Nov 18, 2020
draychev
pushed a commit
to draychev/osm
that referenced
this pull request
Nov 19, 2020
…ervicemesh#2079) This change cleans up a couple of function signatures related to the pod metadata tied to each Envoy proxy by returning the entire struct vs. each field individually to make it more ergonomic.
draychev
pushed a commit
to draychev/osm
that referenced
this pull request
Dec 14, 2020
…ervicemesh#2079) This change cleans up a couple of function signatures related to the pod metadata tied to each Envoy proxy by returning the entire struct vs. each field individually to make it more ergonomic.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change cleans up a couple of function signatures related to the pod
metadata tied to each Envoy proxy by returning the entire struct vs.
each field individually to make it more ergonomic. No functional changes.
I plan to add more fields to the PodMetadata struct so we can use it for SMI
metrics so this change will make that a bit simpler.
Affected area:
Please answer the following questions with yes/no.
No