This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
tests/e2e: isolate framework from tests, restructure files #2090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New file structure:
tests/
framework/
# Contains framework files. Importing these will automatically
# set up init, BeaforeEach, AfterEach... hooks we usually run
# between tests.
e2e/
# contains end-to-end tests.
scenarios/
# Contains larger, use-case driven tests that might benefit from
# using framework itself.
- Updated some README.md references
- Moved framework specific files to "framework" folder.
- Made most of the usable framework structures and attributess
public for importing modules/tests to use.
- Moved mutating_webhook scenario under scenarios.
Signed-off-by: Eduard Serra <eduser25@gmail.com>
eduser25
force-pushed
the
test-file-structure
branch
from
cd86eb3 to
db73205
Compare
Signed-off-by: Eduard Serra <eduser25@gmail.com>
eduser25
force-pushed
the
test-file-structure
branch
from
2bef582 to
c320b15
Compare
Codecov Report
@@ Coverage Diff @@
## main #2090 +/- ##
==========================================
- Coverage 58.35% 58.34% -0.02%
==========================================
Files 143 143
Lines 5869 5869
==========================================
- Hits 3425 3424 -1
- Misses 2442 2443 +1
Partials 2 2
Continue to review full report at Codecov.
|
nojnhuh
previously approved these changes
Nov 19, 2020
snehachhabria
previously approved these changes
Nov 19, 2020
eduser25
force-pushed
the
test-file-structure
branch
from
5851d12 to
3e87485
Compare
nojnhuh
approved these changes
Nov 19, 2020
shashankram
approved these changes
Nov 19, 2020
draychev
reviewed
Nov 19, 2020
| . "github.com/onsi/gomega" | ||
| ) | ||
|
|
||
| func TestSuite(t *testing.T) { |
draychev
approved these changes
Nov 19, 2020
draychev
pushed a commit
to draychev/osm
that referenced
this pull request
Dec 14, 2020
…cemesh#2090) * tests/e2e: isolate framework from tests, restructure files New file structure: tests/ framework/ # Contains framework files. Importing these will automatically # set up init, BeaforeEach, AfterEach... hooks we usually run # between tests. e2e/ # contains end-to-end tests. scenarios/ # Contains larger, use-case driven tests that might benefit from # using framework itself. - Updated some README.md references - Moved framework specific files to "framework" folder. - Made most of the usable framework structures and attributess public for importing modules/tests to use. - Moved mutating_webhook scenario under scenarios. Signed-off-by: Eduard Serra <eduser25@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New file structure:
set up init, BeaforeEach, AfterEach... hooks we usually run
between tests.
using framework itself.
Changes:
public for importing modules/tests to use.
Affected area:
Please answer the following questions with yes/no.
No