Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

envoy/lds: move mesh related filter chain code to its file #2094

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

shashankram
Copy link
Member

Description:
Moves code related to building outbound mesh filter chain
to the inmesh.go file which deals with in-mesh listener components.

Signed-off-by: Shashank Ram shashank08@gmail.com

Affected area:

  • New Functionality [ ]
  • Documentation [ ]
  • Install [ ]
  • Control Plane [ ]
  • CLI Tool [ ]
  • Certificate Management [ ]
  • Networking [ ]
  • Metrics [ ]
  • SMI Policy [ ]
  • Security [ ]
  • Tests [ ]
  • CI System [ ]
  • Performance [ ]
  • Other [X]

Please answer the following questions with yes/no.

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
    No

Moves code related to building outbound mesh filter chain
to the `inmesh.go` file which deals with in-mesh listener components.

Signed-off-by: Shashank Ram <shashank08@gmail.com>
@shashankram shashankram requested a review from a team as a code owner November 19, 2020 18:42
@codecov-io
Copy link

Codecov Report

Merging #2094 (010a1da) into main (f20c7b5) will decrease coverage by 0.11%.
The diff coverage is 84.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2094      +/-   ##
==========================================
- Coverage   58.71%   58.59%   -0.12%     
==========================================
  Files         144      144              
  Lines        5920     5920              
==========================================
- Hits         3476     3469       -7     
- Misses       2442     2449       +7     
  Partials        2        2              
Impacted Files Coverage Δ
pkg/envoy/lds/listener.go 27.08% <ø> (-11.76%) ⬇️
pkg/envoy/lds/inmesh.go 85.18% <84.00%> (-1.03%) ⬇️
pkg/catalog/catalog.go 77.41% <0.00%> (-22.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f20c7b5...010a1da. Read the comment docs.

@shashankram shashankram merged commit e2ed301 into openservicemesh:main Nov 19, 2020
@shashankram shashankram deleted the mesh-fc branch November 19, 2020 19:04
draychev pushed a commit to draychev/osm that referenced this pull request Dec 14, 2020
…cemesh#2094)

Moves code related to building outbound mesh filter chain
to the `inmesh.go` file which deals with in-mesh listener components.

Signed-off-by: Shashank Ram <shashank08@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants