This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
osm: disable ticker, space k8s resyncs to 5m #2095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduser25
force-pushed
the
disable-resyncs
branch
from
c0e0e38 to
819bcf6
Compare
shashankram
reviewed
Nov 19, 2020
Not Final. TBD if/how do we want this. - OSM does not require this at this time to properly function. - Even when they don't do anything, DeepEqual over all catalog objects does take a rather quantifiable amount of cpu cycles. Signed-off-by: Eduard Serra <eduser25@gmail.com>
- Ticker disabled - Kubernetes resyncs scheduled for 5mins This is to make sure that resyncs are never the go-to behavior at testing time. Opened issue to make these programable openservicemesh#2103 Signed-off-by: Eduard Serra <eduser25@gmail.com>
Signed-off-by: Eduard Serra <eduser25@gmail.com>
eduser25
force-pushed
the
disable-resyncs
branch
from
da2917e to
a4ba021
Compare
Codecov Report
@@ Coverage Diff @@
## main #2095 +/- ##
==========================================
- Coverage 58.56% 58.38% -0.19%
==========================================
Files 144 144
Lines 5906 5911 +5
==========================================
- Hits 3459 3451 -8
- Misses 2444 2457 +13
Partials 3 3
Continue to review full report at Codecov.
|
eduser25
changed the title
shashankram
approved these changes
Nov 20, 2020
draychev
reviewed
Nov 20, 2020
| @@ -17,7 +17,8 @@ import ( | |||
|
|
|||
| const ( | |||
| // this is catalog's tick rate for ticker, which triggers global proxy updates | |||
| updateAtLeastEvery = 30 * time.Second | |||
| // 0 disables the ticker | |||
| updateAtLeastEvery = 0 * time.Second | |||
draychev
approved these changes
Nov 20, 2020
|
I plan to introduce some configurability on it next week. Not going to be dead code, no worries. |
draychev
pushed a commit
to draychev/osm
that referenced
this pull request
Dec 14, 2020
osm: disable config replay/resync mechs by default OSM does not hard-require periodic re-configs to guarantee state correctness in its current form. In order to help maintain this statu quo, we will disable ticker and increase the k8s resync period, which will help catch issues that break on-event updates at testing/CI time. Since we still believe periodic arbitrary resyncs could be something that we still might want to have at later time/different circumstances, to ensure config correctness, we will add configurability into ticker and resync intervals in a later patch (openservicemesh#2103). Signed-off-by: Eduard Serra <eduser25@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSM does not hard-require periodic re-configs to guarantee state
correctness in its current form. In order to help maintain this statu quo,
we will disable ticker and increase the k8s resync period, which will
help catch issues that break on-event updates at testing/CI time.
Since we still believe periodic arbitrary resyncs could be something
that we still might want to have at later time/different circumstances, to
ensure config correctness, we will add configurability into ticker and
resync intervals in a later patch (Add runtime config/osm boot flags to configure ticker/resyncs #2103).
Control Plane [X]
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
No