This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
envoy/lds: change HTTP filter's function signature #2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renames the function and changes its signature to remove unused argument. Signed-off-by: Shashank Ram <shashank08@gmail.com>
eduser25
approved these changes
Nov 20, 2020
Codecov Report
@@ Coverage Diff @@
## main #2104 +/- ##
==========================================
+ Coverage 58.52% 58.56% +0.03%
==========================================
Files 144 144
Lines 5914 5910 -4
==========================================
Hits 3461 3461
+ Misses 2450 2446 -4
Partials 3 3
Continue to review full report at Codecov.
|
nojnhuh
approved these changes
Nov 20, 2020
draychev
approved these changes
Nov 20, 2020
|
Is there no linter we can enable to tell us about unused function params? @nojnhuh ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Renames the function and changes its signature to remove
unused argument.
Signed-off-by: Shashank Ram shashank08@gmail.com
Affected area:
Please answer the following questions with yes/no.
No