Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

fluent bit: Add support for outbound http proxy #2114

Merged
merged 6 commits into from
Dec 1, 2020

Conversation

SanyaKochhar
Copy link
Contributor

Description: Adds support for outbound proxy with Fluent Bit. Updates Fluent Bit to v1.6.4.

Affected area:

  • New Functionality [x]
  • Documentation [x]
  • Install [ ]
  • Control Plane [ ]
  • CLI Tool [ ]
  • Certificate Management [ ]
  • Networking [ ]
  • Metrics [ ]
  • SMI Policy [ ]
  • Security [ ]
  • Tests [ ]
  • CI System [ ]
  • Performance [ ]
  • Other [ ]

Please answer the following questions with yes/no.

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
    no, no

@SanyaKochhar SanyaKochhar requested a review from a team as a code owner November 23, 2020 22:47
@codecov-io
Copy link

codecov-io commented Nov 23, 2020

Codecov Report

Merging #2114 (bdf3788) into main (d12f43b) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2114      +/-   ##
==========================================
+ Coverage   58.67%   58.69%   +0.01%     
==========================================
  Files         144      144              
  Lines        5936     5936              
==========================================
+ Hits         3483     3484       +1     
+ Misses       2450     2449       -1     
  Partials        3        3              
Impacted Files Coverage Δ
cmd/cli/dashboard.go 0.00% <0.00%> (ø)
cmd/cli/proxy_configdump.go 4.54% <0.00%> (ø)
pkg/kubernetes/portforward.go 0.00% <ø> (ø)
pkg/envoy/route/config.go 96.03% <0.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc87610...bdf3788. Read the comment docs.

docs/patterns/observability/logs.md Outdated Show resolved Hide resolved
ritazh
ritazh previously approved these changes Dec 1, 2020
Copy link
Contributor

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

SanyaKochhar and others added 5 commits December 1, 2020 14:56
Signed-off-by: Sanya Kochhar <kochhars@microsoft.com>
Signed-off-by: Sanya Kochhar <kochhars@microsoft.com>
Signed-off-by: Sanya Kochhar <kochhars@microsoft.com>
Signed-off-by: Sanya Kochhar <kochhars@microsoft.com>
Signed-off-by: Sanya Kochhar <kochhars@microsoft.com>
Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
Signed-off-by: Sanya Kochhar <kochhars@microsoft.com>
Copy link
Contributor

@michelleN michelleN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SanyaKochhar ! Is there an e2e test scenario that validates the fluentbit integration somewhere?

docs/patterns/observability/logs.md Show resolved Hide resolved
@SanyaKochhar
Copy link
Contributor Author

Thanks @SanyaKochhar ! Is there an e2e test scenario that validates the fluentbit integration somewhere?

@michelleN There's this e2e for fluentbit integration https://github.com/openservicemesh/osm/blob/main/tests/e2e/e2e_fluentbit_test.go - but it doesn't test changes made in this PR

@SanyaKochhar SanyaKochhar requested a review from ritazh December 1, 2020 20:06
@nshankar13
Copy link
Contributor

lgtm

@SanyaKochhar SanyaKochhar merged commit 4c73bd9 into openservicemesh:main Dec 1, 2020
@SanyaKochhar SanyaKochhar deleted the http/fb branch December 1, 2020 21:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants