This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 277
fluent bit: clean up variables and docs for clarity #2116
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanyaKochhar
force-pushed
the
fb/clean
branch
from
November 24, 2020 00:52
3fd1ad2
to
9550c75
Compare
SanyaKochhar
changed the title
fluent bit: refactor configmap conditional for clarity
fluent bit: clean up configmap conditional and docs for clarity
Nov 24, 2020
SanyaKochhar
changed the title
fluent bit: clean up configmap conditional and docs for clarity
fluent bit: clean up variables and docs for clarity
Nov 24, 2020
Codecov Report
@@ Coverage Diff @@
## main #2116 +/- ##
==========================================
- Coverage 58.67% 58.56% -0.11%
==========================================
Files 144 143 -1
Lines 5936 5916 -20
==========================================
- Hits 3483 3465 -18
+ Misses 2450 2448 -2
Partials 3 3
Continue to review full report at Codecov.
|
ritazh
reviewed
Nov 30, 2020
michelleN
reviewed
Nov 30, 2020
ritazh
reviewed
Nov 30, 2020
ritazh
reviewed
Nov 30, 2020
ritazh
reviewed
Nov 30, 2020
ritazh
reviewed
Nov 30, 2020
ritazh
reviewed
Nov 30, 2020
michelleN
reviewed
Nov 30, 2020
ritazh
reviewed
Dec 1, 2020
ritazh
previously approved these changes
Dec 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Just one nit
SanyaKochhar
force-pushed
the
fb/clean
branch
from
December 1, 2020 21:14
87937b6
to
bd99449
Compare
Signed-off-by: Sanya Kochhar <kochhars@microsoft.com>
SanyaKochhar
force-pushed
the
fb/clean
branch
from
December 1, 2020 23:17
bd99449
to
fff8432
Compare
ritazh
previously approved these changes
Dec 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ksubrmnn
previously approved these changes
Dec 1, 2020
shashankram
reviewed
Dec 1, 2020
michelleN
previously approved these changes
Dec 2, 2020
Signed-off-by: Sanya Kochhar <kochhars@microsoft.com>
SanyaKochhar
dismissed stale reviews from michelleN, ksubrmnn, and ritazh
via
December 2, 2020 17:58
557e65b
shashankram
approved these changes
Dec 2, 2020
ritazh
approved these changes
Dec 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sanya Kochhar kochhars@microsoft.com
Description: Updates fluent bit variables and docs
Affected area:
Please answer the following questions with yes/no.