Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

fluent bit: clean up variables and docs for clarity #2116

Merged
merged 3 commits into from
Dec 2, 2020

Conversation

SanyaKochhar
Copy link
Contributor

@SanyaKochhar SanyaKochhar commented Nov 24, 2020

Signed-off-by: Sanya Kochhar kochhars@microsoft.com

Description: Updates fluent bit variables and docs

Affected area:

  • New Functionality [ ]
  • Documentation [ ]
  • Install [ ]
  • Control Plane [ ]
  • CLI Tool [ ]
  • Certificate Management [ ]
  • Networking [ ]
  • Metrics [ ]
  • SMI Policy [ ]
  • Security [ ]
  • Tests [ ]
  • CI System [ ]
  • Performance [ ]
  • Other [x]

Please answer the following questions with yes/no.

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

@SanyaKochhar SanyaKochhar requested a review from a team as a code owner November 24, 2020 00:37
@SanyaKochhar SanyaKochhar changed the title fluent bit: refactor configmap conditional for clarity fluent bit: clean up configmap conditional and docs for clarity Nov 24, 2020
@SanyaKochhar SanyaKochhar changed the title fluent bit: clean up configmap conditional and docs for clarity fluent bit: clean up variables and docs for clarity Nov 24, 2020
@codecov-io
Copy link

codecov-io commented Nov 24, 2020

Codecov Report

Merging #2116 (557e65b) into main (4c73bd9) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2116      +/-   ##
==========================================
- Coverage   58.67%   58.56%   -0.11%     
==========================================
  Files         144      143       -1     
  Lines        5936     5916      -20     
==========================================
- Hits         3483     3465      -18     
+ Misses       2450     2448       -2     
  Partials        3        3              
Impacted Files Coverage Δ
pkg/catalog/routes.go 81.86% <0.00%> (-0.68%) ⬇️
pkg/trafficpolicy/trafficpolicy.go
pkg/envoy/route/config.go 96.03% <0.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c73bd9...557e65b. Read the comment docs.

charts/osm/README.md Outdated Show resolved Hide resolved
charts/osm/values.schema.json Outdated Show resolved Hide resolved
charts/osm/values.schema.json Outdated Show resolved Hide resolved
ritazh
ritazh previously approved these changes Dec 1, 2020
Copy link
Contributor

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Just one nit

Signed-off-by: Sanya Kochhar <kochhars@microsoft.com>
ritazh
ritazh previously approved these changes Dec 1, 2020
Copy link
Contributor

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ksubrmnn
ksubrmnn previously approved these changes Dec 1, 2020
michelleN
michelleN previously approved these changes Dec 2, 2020
Signed-off-by: Sanya Kochhar <kochhars@microsoft.com>
@SanyaKochhar SanyaKochhar dismissed stale reviews from michelleN, ksubrmnn, and ritazh via 557e65b December 2, 2020 17:58
Copy link
Contributor

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SanyaKochhar SanyaKochhar merged commit 4ee242b into openservicemesh:main Dec 2, 2020
@SanyaKochhar SanyaKochhar deleted the fb/clean branch December 4, 2020 17:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants