Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

grafana: QoL updates and fixes #2119

Merged
merged 4 commits into from
Nov 25, 2020
Merged

Conversation

eduser25
Copy link
Contributor

@eduser25 eduser25 commented Nov 24, 2020

  • Remote rendering: New option will install grafana's remote
    rendering engine along with grafana, in same pod.
    Remote rendering will be used to automate taking snapshots of
    dashboards or graphs, which will be useful to automate getting
    comprehensive results for testing.

  • Updated and fixed mesh details to automatically be loaded
    by grafana on config.

  • Addressed other minor fixes in the dashboard itself for proper
    visibility.

Affected area:

  • New Functionality [X]

  • Metrics [X]

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
    No

@eduser25 eduser25 requested a review from a team as a code owner November 24, 2020 20:50
- Remote rendering: New option will install grafana's remote
rendering engine along with grafana, in same pod.

Remote rendering will be used to automate taking snapshots of
dashboards or graphs, which will be useful to automate getting
comprehensive results for testing.

- Updated and fixed mesh details to automatically be loaded
by grafana on config.

Signed-off-by: Eduard Serra <eduser25@gmail.com>
Signed-off-by: Eduard Serra <eduser25@gmail.com>
@eduser25
Copy link
Contributor Author

eduser25 commented Nov 24, 2020

Mesh details example:
image

@codecov-io
Copy link

codecov-io commented Nov 24, 2020

Codecov Report

Merging #2119 (941e850) into main (fb072dc) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2119      +/-   ##
==========================================
+ Coverage   58.66%   58.70%   +0.03%     
==========================================
  Files         144      144              
  Lines        5920     5930      +10     
==========================================
+ Hits         3473     3481       +8     
- Misses       2444     2446       +2     
  Partials        3        3              
Impacted Files Coverage Δ
pkg/envoy/lds/inmesh.go 76.74% <0.00%> (-8.55%) ⬇️
pkg/envoy/lds/response.go 7.27% <0.00%> (+0.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb072dc...941e850. Read the comment docs.

Remove extra large legend for k8s api event rates

Signed-off-by: Eduard Serra <eduser25@gmail.com>
@eduser25 eduser25 merged commit 6699a34 into openservicemesh:main Nov 25, 2020
@eduser25 eduser25 deleted the grafanaFixes branch November 25, 2020 18:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants