This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
[RFC] docs/design: proposal to determine application protocol #2127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a proposal doc to address the need to be able to determine the application protocol served by a service's port. Part of openservicemesh#1521 Signed-off-by: Shashank Ram <shashank08@gmail.com>
eduser25
previously approved these changes
Nov 30, 2020
shashankram
changed the title
draychev
reviewed
Nov 30, 2020
Signed-off-by: Shashank Ram <shashank08@gmail.com>
shashankram
force-pushed
the
app-proto-doc
branch
from
dd2d1b8 to
ba116f0
Compare
draychev
previously approved these changes
Dec 1, 2020
There was a problem hiding this comment.
@shashankram thanks for adding the examples!
I added a few comments to the YAML.
LGTM
Signed-off-by: Shashank Ram <shashank08@gmail.com>
Signed-off-by: Shashank Ram <shashank08@gmail.com>
eduser25
approved these changes
Dec 1, 2020
snehachhabria
approved these changes
Dec 1, 2020
michelleN
approved these changes
Dec 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change adds a proposal doc to address the need to be able
to determine the application protocol served by a service's port.
Part of #1521
Signed-off-by: Shashank Ram shashank08@gmail.com
Affected area:
Please answer the following questions with yes/no.
No