This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
tests/e2e: EnableNsMetrics and EnableDebugServer enabled by default #2130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New options to configure tagging the Namespaces with OSM tag annotations to expose prometheus endpoints have been added, and are enabled by default. Minor also: enable Debug server by default for all testing, when not overriden by the test. Signed-off-by: Eduard Serra <eduser25@gmail.com>
eduser25
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2130 +/- ##
==========================================
- Coverage 58.70% 58.69% -0.01%
==========================================
Files 144 144
Lines 5930 5936 +6
==========================================
+ Hits 3481 3484 +3
- Misses 2446 2449 +3
Partials 3 3
Continue to review full report at Codecov.
|
snehachhabria
approved these changes
Dec 1, 2020
nojnhuh
approved these changes
Dec 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new option to configure tagging the Namespaces with OSM annotations
to expose prometheus endpoints have been added, and are enabled by default.
Minor also: enable Debug server by default for all testing, when
not overriden by the test.
Tests [X]
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
No