Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

catalog: add api to fetch service's port:protocol mapping across prov… #2137

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

shashankram
Copy link
Member

Description:
Adds an api to the MeshCataloger interface to fetch the port:protocol
mapping for a service's ports. Some safety checks have been put in place
to ensure the port:protocol mapping for a service's endpoints is the
same across providers.

Affected area:

  • New Functionality [ ]
  • Documentation [ ]
  • Install [ ]
  • Control Plane [X]
  • CLI Tool [ ]
  • Certificate Management [ ]
  • Networking [ ]
  • Metrics [ ]
  • SMI Policy [ ]
  • Security [ ]
  • Tests [ ]
  • CI System [ ]
  • Performance [ ]
  • Other [ ]

Please answer the following questions with yes/no.

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
    No

…iders

Adds an api to the MeshCataloger interface to fetch the port:protocol
mapping for a service's ports. Some safety checks have been put in place
to ensure the port:protocol mapping for a service's endpoints is the
same across providers.

Signed-off-by: Shashank Ram <shashank08@gmail.com>
@shashankram shashankram requested a review from a team as a code owner December 2, 2020 23:49
@codecov-io
Copy link

Codecov Report

Merging #2137 (f010b97) into main (27379ac) will decrease coverage by 0.43%.
The diff coverage is 16.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2137      +/-   ##
==========================================
- Coverage   58.28%   57.84%   -0.44%     
==========================================
  Files         143      144       +1     
  Lines        5933     5995      +62     
==========================================
+ Hits         3458     3468      +10     
- Misses       2472     2524      +52     
  Partials        3        3              
Impacted Files Coverage Δ
pkg/catalog/mock_catalog.go 0.00% <0.00%> (ø)
pkg/endpoint/mock_provider.go 0.00% <0.00%> (ø)
pkg/catalog/service.go 91.66% <83.33%> (-8.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27379ac...f010b97. Read the comment docs.

@shashankram shashankram merged commit 54719f8 into openservicemesh:main Dec 3, 2020
@shashankram shashankram deleted the app-proto-catalog branch December 3, 2020 00:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants