This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 276
tests/framework: additions to framework to query from Prometheus/Grafana #2138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds few open helpers to allow querying for various resources on both Prometheus and Grafana. Particularly, the current helpers added are sufficient to match and record CPU and Memory trends, as well as graphing the overall control plane namespace CPU and memory consumption through Grafana remote rendering.
Signed-off-by: Eduard Serra <eduser25@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2138 +/- ##
==========================================
- Coverage 58.67% 57.86% -0.82%
==========================================
Files 144 144
Lines 5936 5995 +59
==========================================
- Hits 3483 3469 -14
- Misses 2450 2523 +73
Partials 3 3
Continue to review full report at Codecov.
|
nojnhuh
previously approved these changes
Dec 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple nits, but LGTM. Will definitely use this for custom metrics tests.
nojnhuh
approved these changes
Dec 3, 2020
snehachhabria
approved these changes
Dec 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds few high level helpers to allow querying for various resources
on both Prometheus and Grafana. Intention is to use them in our test infrastructure
to gather a holistic look on data and metrics on processes, namely control plane ones
(but not limited to).
The current set of helpers added are sufficient query and track
CPU and Memory trends, as well as graphing the overall control plane namespace
CPU and memory consumption through Grafana remote rendering, all at any point
during a test.
For graphing, Grafana remote rendering and specific dashboards which already
target the data to be graphed are needed.
This is part of an effort to better instrument our tests and potentially unlock minimal scale
testing using the very same tools we've written our tests with.
Relevant APIs:
Please answer the following questions with yes/no.
No