This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
envoy/lds: create inbound filter chains per service port #2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes the inbound filter chains for in-mesh and ingress a per port construct, so that protocol specific filters and rules can be enforced per port. Since protocol specific filters (ex. TCP proxy vs HTTP Connection Manager) cannot be filter on the same filter chain, a port specific filter chain is created to be able to handle per port:protocol filtering. Additionally, this change adds new tests for the ingress filter chain and updates the existing tests for mesh filter chains. This is required for TCP filtering and routing: openservicemesh#1521 Signed-off-by: Shashank Ram <shashank08@gmail.com>
draychev
approved these changes
Dec 3, 2020
Codecov Report
@@ Coverage Diff @@
## main #2140 +/- ##
==========================================
- Coverage 57.86% 57.81% -0.06%
==========================================
Files 144 144
Lines 5995 6021 +26
==========================================
+ Hits 3469 3481 +12
- Misses 2523 2537 +14
Partials 3 3
Continue to review full report at Codecov.
|
eduser25
approved these changes
Dec 3, 2020
| @@ -57,27 +65,43 @@ func newIngressFilterChain(cfg configurator.Configurator, svc service.MeshServic | |||
| } | |||
| } | |||
|
|
|||
| func getIngressFilterChains(svc service.MeshService, cfg configurator.Configurator) []*xds_listener.FilterChain { | |||
| func (lb *listenerBuilder) getIngressFilterChains(svc service.MeshService) []*xds_listener.FilterChain { | |||
There was a problem hiding this comment.
nit, unrelated to the commit, should it be ForService?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change makes the inbound filter chains for in-mesh
and ingress a per port construct, so that protocol
specific filters and rules can be enforced per port.
Since protocol specific filters (ex. TCP proxy vs HTTP
Connection Manager) cannot be filters on the same filter
chain, a port specific filter chain is created to be
able to handle per port:protocol filtering.
Additionally, this change adds new tests for the ingress
filter chain and updates the existing tests for mesh filter
chains. The file
lds/response_test.gowas ingress specificand has been rewritten to
lds/ingress_test.go.This is required for TCP filtering and routing: #1521
Affected area:
Please answer the following questions with yes/no.
No