This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
envoy/lds: add support for inbound TCP proxying #2154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds the plumbing necessary to be able to proxy indbound TCP traffic for a service. Similar to the inbound HTTP filter chain, a TCP filter chain is adder per TCP port exposed on the service. This is the first change in the series to support TCP traffic. Subsequent changes will enable enforcing TCP port based rules as a part of the RBAC policies. Note that this change will not allow TCP clients to access TCP based services yet because outbound TCP proxying with TLS still needs to be implemented. This change does not affect HTTP traffic. Part of openservicemesh#1521 Signed-off-by: Shashank Ram <shashr2204@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2154 +/- ##
==========================================
+ Coverage 58.10% 58.23% +0.12%
==========================================
Files 145 145
Lines 6075 6127 +52
==========================================
+ Hits 3530 3568 +38
- Misses 2542 2556 +14
Partials 3 3
Continue to review full report at Codecov.
|
eduser25
reviewed
Dec 7, 2020
eduser25
reviewed
Dec 7, 2020
eduser25
reviewed
Dec 7, 2020
eduser25
approved these changes
Dec 7, 2020
snehachhabria
approved these changes
Dec 8, 2020
michelleN
approved these changes
Dec 8, 2020
michelleN
pushed a commit
to michelleN/osm
that referenced
this pull request
Dec 8, 2020
This change adds the plumbing necessary to be able to proxy indbound TCP traffic for a service. Similar to the inbound HTTP filter chain, a TCP filter chain is adder per TCP port exposed on the service. This is the first change in the series to support TCP traffic. Subsequent changes will enable enforcing TCP port based rules as a part of the RBAC policies. Note that this change will not allow TCP clients to access TCP based services yet because outbound TCP proxying with TLS still needs to be implemented. This change does not affect HTTP traffic. Part of openservicemesh#1521 Signed-off-by: Shashank Ram <shashr2204@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change adds the plumbing necessary to be able to
proxy indbound TCP traffic for a service. Similar to
the inbound HTTP filter chain, a TCP filter chain
is adder per TCP port exposed on the service. This
is the first change in the series to support TCP traffic.
Subsequent changes will enable enforcing TCP port based
rules as a part of the RBAC policies.
Note that this change will not allow TCP clients to access
TCP based services yet because outbound TCP proxying with
TLS still needs to be implemented. This change does not
affect HTTP traffic.
Part of #1521
Affected area:
Please answer the following questions with yes/no.
No