This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
fix(fluent bit): make input plugin read from head of file #2158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2158 +/- ##
==========================================
+ Coverage 58.23% 58.25% +0.01%
==========================================
Files 145 145
Lines 6127 6127
==========================================
+ Hits 3568 3569 +1
+ Misses 2556 2555 -1
Partials 3 3
Continue to review full report at Codecov.
|
michelleN
approved these changes
Dec 8, 2020
michelleN
previously approved these changes
Dec 8, 2020
nshankar13
previously approved these changes
Dec 8, 2020
|
lgtm |
@michelleN agreed, I've been trying to figure out how to test this and other scenarios where logs could be missed but haven't been able to find an efficient way yet. Opened this issue to track it #2159 |
Signed-off-by: Sanya Kochhar <kochhars@microsoft.com>
SanyaKochhar
dismissed stale reviews from nshankar13 and michelleN
via
d1ec77a
SanyaKochhar
force-pushed
the
missing-logs
branch
from
795fe04 to
d1ec77a
Compare
michelleN
approved these changes
Dec 8, 2020
ritazh
approved these changes
Dec 8, 2020
nshankar13
approved these changes
Dec 8, 2020
michelleN
pushed a commit
to michelleN/osm
that referenced
this pull request
Dec 8, 2020
…ervicemesh#2158) Signed-off-by: Sanya Kochhar <kochhars@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This change updates the Fluent Bit input plugin to make it read from the head of the log file rather than the tail. Reading from the tail was causing the first few logs to be missed.
Affected area:
Please answer the following questions with yes/no.
no, no