Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

docs(release): clarify remotes in release guide #2166

Merged
merged 3 commits into from
Dec 9, 2020
Merged

docs(release): clarify remotes in release guide #2166

merged 3 commits into from
Dec 9, 2020

Conversation

nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Dec 8, 2020

Description:
This change makes clear that git push commands in the release process
should go to the remote representing the main repo, not forks. It
changes the example origin name from origin to upstream to reduce
accidental pushes to forks and better stand out in command snippets.

Affected area:

  • New Functionality [ ]
  • Documentation [X]
  • Install [ ]
  • Control Plane [ ]
  • CLI Tool [ ]
  • Certificate Management [ ]
  • Networking [ ]
  • Metrics [ ]
  • SMI Policy [ ]
  • Security [ ]
  • Tests [ ]
  • CI System [ ]
  • Performance [ ]
  • Other [ ]

Please answer the following questions with yes/no.

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
    No

This change makes clear that `git push` commands in the release process
should go to the remote representing the main repo, not forks. It
changes the example origin name from `origin` to `upstream` to reduce
accidental pushes to forks and better stand out in command snippets.

Signed-off-by: Jon Huhn <johuhn@microsoft.com>
@nojnhuh nojnhuh requested a review from SanyaKochhar December 8, 2020 22:23
@nojnhuh nojnhuh requested a review from a team as a code owner December 8, 2020 22:23
@nojnhuh nojnhuh merged commit 0d40ccb into openservicemesh:main Dec 9, 2020
@nojnhuh nojnhuh deleted the release-guide-remote branch December 9, 2020 16:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants