This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
fix(e2e): gracefully stop port forwarding to Prometheus/Grafana #2182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds the ability to stop the port-forward that happens when getting a handle to Prometheus or Grafana to support detaching and reattaching in the middle of a test. Signed-off-by: Jon Huhn <johuhn@microsoft.com>
shashankram
approved these changes
Dec 10, 2020
Codecov Report
@@ Coverage Diff @@
## main #2182 +/- ##
==========================================
+ Coverage 58.38% 58.40% +0.01%
==========================================
Files 145 145
Lines 6169 6169
==========================================
+ Hits 3602 3603 +1
+ Misses 2564 2563 -1
Partials 3 3
Continue to review full report at Codecov.
|
eduser25
approved these changes
Dec 10, 2020
draychev
approved these changes
Dec 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change adds the ability to stop the port-forward that happens when
getting a handle to Prometheus or Grafana to support detaching and
reattaching in the middle of a test.
Affected area:
Please answer the following questions with yes/no.
No