Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

fluent bit: add identifier to help query logs in output #2195

Merged
merged 3 commits into from
Dec 15, 2020
Merged

fluent bit: add identifier to help query logs in output #2195

merged 3 commits into from
Dec 15, 2020

Conversation

SanyaKochhar
Copy link
Contributor

@SanyaKochhar SanyaKochhar commented Dec 14, 2020 •
edited
Loading

Description:

  • Adds the osm controller name as a key/value pair in the logs to help users query/refine log output
  • Makes environment variables explicitly defined

Affected area:

  • New Functionality [ ]
  • Documentation [ ]
  • Install [ ]
  • Control Plane [ ]
  • CLI Tool [ ]
  • Certificate Management [ ]
  • Networking [ ]
  • Metrics [ ]
  • SMI Policy [ ]
  • Security [ ]
  • Tests [ ]
  • CI System [ ]
  • Performance [ ]
  • Other [x]

Please answer the following questions with yes/no.

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
    no, no

@SanyaKochhar SanyaKochhar requested a review from a team as a code owner December 14, 2020 18:46
ritazh
ritazh previously approved these changes Dec 14, 2020
View reviewed changes
michelleN
michelleN previously approved these changes Dec 15, 2020
View reviewed changes
@SanyaKochhar
Add controller pod name to logs
db042e4 
Signed-off-by: Sanya Kochhar <kochhars@microsoft.com>
@SanyaKochhar
Combine modify filters
f780d92 
Signed-off-by: Sanya Kochhar <kochhars@microsoft.com>
@SanyaKochhar
Update doc to explain identifier
e717888 
Signed-off-by: Sanya Kochhar <kochhars@microsoft.com>
@SanyaKochhar SanyaKochhar dismissed stale reviews from michelleN and ritazh via e717888 December 15, 2020 17:17
shalier
shalier approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@shalier shalier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SanyaKochhar SanyaKochhar merged commit 8f40c88 into openservicemesh:main Dec 15, 2020
@SanyaKochhar SanyaKochhar deleted the fb/identifier branch December 15, 2020 17:49
SanyaKochhar added a commit to SanyaKochhar/osm that referenced this pull request Jan 8, 2021
@SanyaKochhar
fluent bit: add identifier to help query logs in output (openservicem…
d0b1eb3 
…esh#2195)

* Add controller pod name to logs

Signed-off-by: Sanya Kochhar <kochhars@microsoft.com>
SanyaKochhar added a commit to SanyaKochhar/osm that referenced this pull request Jan 11, 2021
@SanyaKochhar
fluent bit: add identifier to help query logs in output (openservicem…
78e26d0 
…esh#2195)

* Add controller pod name to logs

Signed-off-by: Sanya Kochhar <kochhars@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shalier shalier shalier approved these changes

@michelleN michelleN michelleN approved these changes

@ritazh ritazh Awaiting requested review from ritazh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SanyaKochhar @michelleN @ritazh @shalier