This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
fix(ci): workaround DCO requirement for gh-pages branch #2203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a step to the chart release CI workflow to force git to signoff commits to pass the DCO check. Signed-off-by: Jon Huhn <johuhn@microsoft.com>
SanyaKochhar
approved these changes
Dec 15, 2020
| @@ -9,6 +9,8 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - uses: actions/checkout@v2 | |||
| # Workaround DCO requirement for gh-pages branch | |||
| - run: git config alias.commit "commit -s" | |||
| - name: Publish Helm charts | |||
| uses: stefanprodan/helm-gh-pages@v1.1.0 | |||
There was a problem hiding this comment.
Should we update to v1.3.0 as well?
There was a problem hiding this comment.
Looking at the changes, I don't see anything that we need or would use. I could make that a separate change if there's something I'm missing.
https://github.com/stefanprodan/helm-gh-pages/releases
phillipgibson
approved these changes
Dec 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change adds a step to the chart release CI workflow to force git to
signoff commits to pass the DCO check.
Affected area:
Please answer the following questions with yes/no.
No