This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
metrics: expose metrics for number of connected proxies #2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a metric for the number of connected proxies. Part of openservicemesh#902 Signed-off-by: Shashank Ram <shashr2204@gmail.com>
eduser25
approved these changes
Jan 9, 2021
shashankram
commented
Jan 9, 2021
| # TYPE osm_k8s_api_event_count counter | ||
| osm_k8s_api_event_count %d | ||
| `, i /* api event count */) | ||
| assert.Contains(rr.Body.String(), expectedResp) | ||
| } | ||
| } | ||
|
|
||
| func TestProxyConnectCount(t *testing.T) { |
There was a problem hiding this comment.
This test is not too important. Eventually we will group metrics by their category (counter, guage etc.) for basic coverage.
draychev
approved these changes
Jan 9, 2021
eduser25
pushed a commit
to eduser25/osm
that referenced
this pull request
Jan 11, 2021
…esh#2278) Adds a metric for the number of connected proxies. Part of openservicemesh#902 Signed-off-by: Shashank Ram <shashr2204@gmail.com> Signed-off-by: Eduard Serra <eduser25@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds a metric for the number of connected proxies.
Part of #902
Signed-off-by: Shashank Ram shashr2204@gmail.com
Affected area:
Please answer the following questions with yes/no.
No