Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

logging: remove response from log #2321

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

SanyaKochhar
Copy link
Contributor

Signed-off-by: Sanya Kochhar kochhars@microsoft.com

Description: Closes #2309

Affected area:

  • New Functionality [ ]
  • Documentation [ ]
  • Install [ ]
  • Control Plane [ ]
  • CLI Tool [ ]
  • Certificate Management [ ]
  • Networking [ ]
  • Metrics [ ]
  • SMI Policy [ ]
  • Security [ ]
  • Tests [ ]
  • CI System [ ]
  • Performance [ ]
  • Other [x]

Please answer the following questions with yes/no.

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
    no, no

@SanyaKochhar SanyaKochhar requested a review from a team as a code owner January 19, 2021 23:04
Signed-off-by: Sanya Kochhar <kochhars@microsoft.com>
@codecov-io
Copy link

Codecov Report

Merging #2321 (d9da845) into main (8f85d4f) will decrease coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2321      +/-   ##
==========================================
- Coverage   57.29%   57.08%   -0.22%     
==========================================
  Files         150      150              
  Lines        6718     6715       -3     
==========================================
- Hits         3849     3833      -16     
- Misses       2864     2877      +13     
  Partials        5        5              
Impacted Files Coverage Δ
pkg/envoy/ads/response.go 74.07% <100.00%> (-0.93%) ⬇️
pkg/configurator/validating_webhook.go 68.84% <0.00%> (-10.15%) ⬇️
pkg/envoy/route/config.go 96.03% <0.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f85d4f...d9da845. Read the comment docs.

@SanyaKochhar SanyaKochhar merged commit c11e267 into openservicemesh:main Jan 20, 2021
@SanyaKochhar SanyaKochhar deleted the logs-req-resp branch January 20, 2021 17:26
@SanyaKochhar SanyaKochhar restored the logs-req-resp branch January 20, 2021 17:26
@SanyaKochhar SanyaKochhar deleted the logs-req-resp branch January 20, 2021 17:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants