-
Notifications
You must be signed in to change notification settings - Fork 277
Conversation
Signed-off-by: Alessandro Vozza <alessandro.vozza@microsoft.com>
@nojnhuh I know correctly entered the comments in the |
Codecov Report
@@ Coverage Diff @@
## main #2322 +/- ##
==========================================
- Coverage 57.25% 57.23% -0.02%
==========================================
Files 149 149
Lines 6660 6660
==========================================
- Hits 3813 3812 -1
- Misses 2842 2843 +1
Partials 5 5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ams0 ! These changes look great. Some of the comments seem like they are duplicates of the line above it. If you could remove the lines above that are duplicates, that would be great. Will merge as soon as that is done.
Signed-off-by: Alessandro Vozza <alessandro.vozza@microsoft.com>
thanks @michelleN ! Also, to be addressed perhaps later, all values are prefixed with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a minor question about the README but I'll go ahead and merge this and we can address the install line in a follow up PR.
## Install Chart | ||
|
||
```console | ||
helm install [RELEASE_NAME] osm/osm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be charts/osm
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it seems that's how it looks in the chart repo:
~> helm search repo osm
NAME CHART VERSION APP VERSION DESCRIPTION
osm/osm 0.6.1 v0.6.1 A Helm chart to install the OSM control plane o...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nojnhuh I know correctly entered the comments in the
values.yaml
and lethelm-docs
generate the readme. I did not actually included the readme as I assume the CI will take care of it?
We actually don't have this automated in CI currently, but we have it documented as a manual step as part of cutting releases. I'm not too worried about everything being perfectly in sync between releases. Thanks for digging in to figure out the helm-docs
details.
Description:
A more descriptive Readme for the Helm chart
Affected area:
Please answer the following questions with yes/no.
No