This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
smi: update to smi-sdk-go v0.5.0 and traffic-specs v1alpha4 #2331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change upgrades the code to use the latest v0.5.0 SMI SDK to be able to support v1alpha4 of SMI traffic-specs APIs. v1alpha4 is primarily required for TCP routes support. Resolves openservicemesh#2318 Signed-off-by: Shashank Ram <shashr2204@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2331 +/- ##
==========================================
- Coverage 57.26% 57.21% -0.05%
==========================================
Files 149 149
Lines 6673 6663 -10
==========================================
- Hits 3821 3812 -9
+ Misses 2847 2846 -1
Partials 5 5
Continue to review full report at Codecov.
|
draychev
reviewed
Jan 20, 2021
michelleN
approved these changes
Jan 20, 2021
| @@ -34,7 +34,7 @@ require ( | |||
| github.com/prometheus/client_golang v1.0.0 | |||
| github.com/prometheus/common v0.4.1 | |||
| github.com/rs/zerolog v1.18.0 | |||
| github.com/servicemeshinterface/smi-sdk-go v0.4.1 | |||
| github.com/servicemeshinterface/smi-sdk-go v0.5.0 | |||
| @@ -179,25 +176,8 @@ func (mc *MeshCatalog) getTCPRouteMatchesFromTrafficTarget(trafficTarget smiAcce | |||
| return nil, errNoTrafficSpecFoundForTrafficPolicy | |||
| } | |||
|
|
|||
| // TODO(#1521): Create an actual TCP route match once v1alpha4 TCPRoute spec is available | |||
| // Hack: derive ports from 'ports' label on the TCPRoute resource | |||
| portsStr, ok := tcpRoute.Labels["ports"] | |||
| tcpRouteMatch := trafficpolicy.TCPRouteMatch{ | ||
| Ports: ports, | ||
| Ports: tcpRoute.Spec.Matches.Ports, |
draychev
approved these changes
Jan 20, 2021
There was a problem hiding this comment.
@shashankram this is great! Thank you!
I left a tiny comment on checking whether Matches is empty - this we could do in fast-followup PR (if at all needed).
Discussed and resolved concern in #2331 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change upgrades the code to use the latest v0.5.0 SMI
SDK to be able to support v1alpha4 of SMI traffic-specs APIs.
v1alpha4 is primarily required for TCP routes support.
Resolves #2318
Signed-off-by: Shashank Ram shashr2204@gmail.com
Affected area:
Please answer the following questions with yes/no.
No