Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

reconciler: Tiny adjustment to a log message #2357

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

draychev
Copy link
Contributor

Tweak the verbiage and capitalization of an error message. Remove .String() as NamespacedName already implements Stringer interface: https://github.com/kubernetes/kubernetes/blob/e79a873b4c0d6ae4d2cd49462e034999f80147d2/staging/src/k8s.io/apimachinery/pkg/types/namespacedname.go#L19-L39


Affected area:

  • New Functionality [ ]
  • Documentation [ ]
  • Install [ ]
  • Control Plane [ ]
  • CLI Tool [ ]
  • Certificate Management [ ]
  • Networking [ ]
  • Metrics [ ]
  • SMI Policy [ ]
  • Security [ ]
  • Tests [ ]
  • CI System [ ]
  • Performance [ ]
  • Other [ ]

Please answer the following questions with yes/no.

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

Signed-off-by: Delyan Raychev <delyan.raychev@microsoft.com>
@draychev draychev requested a review from a team as a code owner January 22, 2021 20:53
@codecov-io
Copy link

Codecov Report

Merging #2357 (7b37a1b) into main (e59da65) will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2357      +/-   ##
==========================================
- Coverage   57.25%   57.04%   -0.22%     
==========================================
  Files         149      149              
  Lines        6660     6660              
==========================================
- Hits         3813     3799      -14     
- Misses       2842     2856      +14     
  Partials        5        5              
Impacted Files Coverage Δ
pkg/configurator/validating_webhook.go 68.84% <0.00%> (-10.15%) ⬇️
pkg/envoy/lds/inmesh.go 54.09% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e59da65...7b37a1b. Read the comment docs.

@draychev draychev merged commit 4e11b98 into openservicemesh:main Jan 22, 2021
@draychev draychev deleted the fix-log-message-a branch January 22, 2021 22:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants