Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

[tests] : Adding unit test for the entire envoy listener configuration #2358

Merged
merged 2 commits into from
Jan 22, 2021

Conversation

snehachhabria
Copy link
Contributor

Description:

This PR adds a unit test for the entire listener configuration.

Fixes : #2056

Signed-off-by: Sneha Chhabria snchh@microsoft.com

Affected area:

  • New Functionality [ ]
  • Documentation [ ]
  • Install [ ]
  • Control Plane [ ]
  • CLI Tool [ ]
  • Certificate Management [ ]
  • Networking [ ]
  • Metrics [ ]
  • SMI Policy [ ]
  • Security [ ]
  • Tests [X]
  • CI System [ ]
  • Performance [ ]
  • Other [ ]

Please answer the following questions with yes/no.

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution? no

pkg/envoy/lds/response_test.go Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Jan 22, 2021

Codecov Report

Merging #2358 (7e193cc) into main (e109d6a) will increase coverage by 1.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2358      +/-   ##
==========================================
+ Coverage   57.23%   58.55%   +1.32%     
==========================================
  Files         149      149              
  Lines        6660     6660              
==========================================
+ Hits         3812     3900      +88     
+ Misses       2843     2746      -97     
- Partials        5       14       +9     
Impacted Files Coverage Δ
pkg/envoy/route/config.go 96.03% <0.00%> (+0.79%) ⬆️
pkg/envoy/lds/inmesh.go 67.27% <0.00%> (+13.18%) ⬆️
pkg/envoy/lds/listener.go 89.06% <0.00%> (+45.31%) ⬆️
pkg/envoy/lds/response.go 60.00% <0.00%> (+52.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e109d6a...7e193cc. Read the comment docs.

Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
@snehachhabria snehachhabria merged commit 1c00c37 into openservicemesh:main Jan 22, 2021
@snehachhabria snehachhabria deleted the ldsTest branch January 25, 2021 19:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unit test to test entire envoy listener configuration
4 participants