Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

catalog: Tweak verbiage of log line #2372

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

draychev
Copy link
Contributor

Minuscule change to the verbiage of a Trace log line

No functional code changes!


Affected area:

  • New Functionality [ ]
  • Documentation [ ]
  • Install [ ]
  • Control Plane [ ]
  • CLI Tool [ ]
  • Certificate Management [ ]
  • Networking [ ]
  • Metrics [ ]
  • SMI Policy [ ]
  • Security [ ]
  • Tests [ ]
  • CI System [ ]
  • Performance [ ]
  • Other [ ]

Please answer the following questions with yes/no.

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

@draychev draychev requested a review from a team as a code owner January 25, 2021 23:08
@codecov-io
Copy link

Codecov Report

Merging #2372 (1e018de) into main (e109d6a) will increase coverage by 1.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2372      +/-   ##
==========================================
+ Coverage   57.23%   58.33%   +1.09%     
==========================================
  Files         149      149              
  Lines        6660     6660              
==========================================
+ Hits         3812     3885      +73     
+ Misses       2843     2761      -82     
- Partials        5       14       +9     
Impacted Files Coverage Δ
pkg/catalog/routes.go 79.03% <100.00%> (ø)
pkg/configurator/validating_webhook.go 68.84% <0.00%> (-10.15%) ⬇️
pkg/envoy/lds/inmesh.go 67.27% <0.00%> (+13.18%) ⬆️
pkg/envoy/lds/listener.go 89.06% <0.00%> (+45.31%) ⬆️
pkg/envoy/lds/response.go 60.00% <0.00%> (+52.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e109d6a...1e018de. Read the comment docs.

@draychev draychev merged commit d8b7249 into openservicemesh:main Jan 26, 2021
@draychev draychev deleted the fix-log-line-b branch January 26, 2021 01:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants